Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PureScript's Halogen v2.1.0 #227

Merged
merged 2 commits into from
Aug 6, 2017
Merged

Add PureScript's Halogen v2.1.0 #227

merged 2 commits into from
Aug 6, 2017

Conversation

thomashoneyman
Copy link
Contributor

Hi @krausest!

I've provided a benchmark of the Halogen framework from PureScript (repo here).

This is a PureScript framework written 100% in PureScript including the virtual DOM. I believe it is the most widely-used framework in production.

@thomashoneyman
Copy link
Contributor Author

thomashoneyman commented Aug 5, 2017

@krausest krausest merged commit 2690e16 into krausest:master Aug 6, 2017
@krausest
Copy link
Owner

krausest commented Aug 6, 2017

Thanks. Results are here.
To be honest - not really impressive. Does halogen support keyed updates?

The disk size is 146MB for halogen which is compared to the 177MB for ember quite ok.

Update: After running the benchmark I noticed that halogen doesn't preload the remove icon. I changed that in commit be8bb0f . I'll update the results soon, but I don't expect that it changes a lot.

@thomashoneyman
Copy link
Contributor Author

I believe it's possible to do a keyed variant also. I've been stretched for time lately but can work on a keyed implementation to see if that has different results.

There are other PureScript frameworks that rely on React (Thermite is basically a wrapper for React) and should be fast for that reason. However, Halogen is 100% PureScript, which both has the benefit of being a joy to develop in and the downside of less investment into performance optimization.

Thanks for the merge!

@krausest
Copy link
Owner

@thomashoneyman I just noticed a bug: If you click "create 1,000 rows" and then "swap rows" the labels, but not the row ids, are swapped.

Can you please take a look at that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants