Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domvm v3.3.2 #396

Merged
merged 1 commit into from
May 21, 2018
Merged

domvm v3.3.2 #396

merged 1 commit into from
May 21, 2018

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented May 19, 2018

hey @krausest,

sorry for the rapid update, but this will be the last one for a while.

i simplified the benchmark implementation, removing a couple micro-optimizations (event delegation, jumbotron redraw skipping). the new impl is also less monolithic and more functional/componentized. v3.3.2 also reworks some event listener internals to use addEventListener rather than binding directly to the dom nodes. also, this PR drops a few old/unused devDependencies, so a bit faster builds :)

in my tests, the perf was within +/-2% and +0.2M in the memory metrics. well worth the clearer code, imo.

thanks!

@krausest krausest merged commit 8e2f50a into krausest:master May 21, 2018
@krausest
Copy link
Owner

Thanks. Perf results look like that:
bildschirmfoto 2018-05-21 um 21 22 05

bildschirmfoto 2018-05-21 um 21 21 53

@leeoniya
Copy link
Contributor Author

these numbers make sense.

the impl is much clearer, so i'm happy about that. in the future i'll see if there's any room to get some of the perf back from internal improvements.

thanks!

@leeoniya leeoniya mentioned this pull request May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants