Bump reflex-dom #500
Merged
Bump reflex-dom #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfmpe
force-pushed
the
bump-reflex-dom
branch
from
9c702e7
to
9a96b8f
Compare
|
Thanks - results are here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of #498 for reflex-dom.
Turns out I had added that remove icon span a year ago, but it wasn't merged to my fork.
I was also getting some build errors on the previous version (probably due to either nix upgrade or mac os update). Should be fixed by this bump.
The 'Duration in milliseconds' geometric mean slowdown has gone from ~5x to over 10x between round 8 and the current results for some reason. I reproduced these strange results on my mac as well. Given that the reflex-dom benchmark hadn't been updated in many months, I suspect some chrome update might not get along with it. With this bump, the value seems to have gone back to ~5x slowdown.