Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MobX benchmark after upgrading by swapping minifier and enabling batching #752

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

mweststrate
Copy link
Contributor

This fixes: mobxjs/mobx-react#877

React became really slow after upgrading to 16.6+, which is caused by a bug in the default webpack minifier (facebook/react#13987). This might apply to other React based frameworks as well.

Also enabled ReactDOM batching support according to best practice.

@krausest krausest added the merging started merging started (no more updates please) label Jun 25, 2020
@krausest krausest merged commit 1609793 into krausest:master Jun 25, 2020
@krausest krausest removed the merging started merging started (no more updates please) label Jun 25, 2020
@krausest
Copy link
Owner

Thanks. Results are updated. I hoped to see a clear improvement in comparison to the old results, but sadly results didn't change much. (System was rebooted before runnning and I'm always running keyed/vanillajs as a check and its results look fine)
How much of an improvement did you expect?

@mweststrate
Copy link
Contributor Author

mweststrate commented Jun 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js framework benchmark - Huge performance drop after upgrading mobx and mobx-react to latest version
2 participants