Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build & install implementations using lerna #762

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

nweldev
Copy link
Contributor

@nweldev nweldev commented Jul 4, 2020

Add two new scripts using lerna in order to ease examples' dependencies install & build:

  • npm run bootstrap: install all implementations' dependencies
  • npm run build-all -- --scope <glob>: build implementations, filtered by their package names
    • example: npm run build-all -- --scope "*vanillajs*"

This required to rename most packages in order to avoid conflicts, as some haven't been updated after copy.

FYI lerna can't be used if several packages have the same name.

@krausest krausest added the merging started merging started (no more updates please) label Jul 7, 2020
@krausest krausest merged commit a18a03c into krausest:master Jul 7, 2020
@krausest krausest removed the merging started merging started (no more updates please) label Jul 7, 2020
@krausest
Copy link
Owner

krausest commented Jul 7, 2020

Thanks. It's merged, but I'd like to name the targets lerna-bootstrap and lerna-build-all.
I'm not yet sold on switching to lerna since I had same painful experience with yarn (#221, #182) and so I avoided looking into lerna so far.
Currently I'm having a rather robust workflow for updating implementations with the docker-rebuild target to do a safe rebuild. Do you have any recommendations how to improve this with lerna?

@nweldev
Copy link
Contributor Author

nweldev commented Jul 7, 2020

Well, actually, I only used lerna here as a quick and dirty way to ease implementations install & build for other contributors (me included). I'm not familiar enough with the docker-rebuild workflow to have any useful opinion on that. I'll try to give it a try when I'll have access to a more powerful computer 😅

But I don't expect Lerna to break anything like yarn used to, as it simply use npm under the hood.

@nweldev nweldev deleted the add-lerna branch July 7, 2020 20:44
@krausest
Copy link
Owner

krausest commented Jul 8, 2020

I put a description of the docker build here: https://github.com/krausest/js-framework-benchmark/wiki/Build-all-frameworks-with-docker
I guess I wouldn‘t use it for development, since the turnaround times of a clean npm install and npm build-prod is much higher than hot reloading like the build-dev target often allows. But it‘s really great for maintenance since the docker-rebuild target allows rebuilding and checking one implementation in a controlled environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants