Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Commit

Permalink
pam: don't leak TACACS+ secret to journald
Browse files Browse the repository at this point in the history
If journald for syslog is used, the journal is going to store everything,
even DEBUG loglevel messages. Pre-journald logging of system-wide DEBUG
loglevel could be avoided and is not affected in all cases.

With journald presence it's probably safe to no longer log sensitive
details at DEBUG level.

Fix #149

Signed-off-by: Daniel Gollub <dgollub@att.com>
  • Loading branch information
gollub committed Jun 2, 2020
1 parent e1f842c commit 4a9852c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions support.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ int _pam_parse(int argc, const char **argv) {
_pam_log(LOG_DEBUG, "%d servers defined", tac_srv_no);

for (n = 0; n < tac_srv_no; n++) {
_pam_log(LOG_DEBUG, "server[%lu] { addr=%s, key='%s' }", n, tac_ntop(tac_srv[n].addr->ai_addr),
tac_srv[n].key);
_pam_log(LOG_DEBUG, "server[%lu] { addr=%s, key='********' }", n,
tac_ntop(tac_srv[n].addr->ai_addr));
}

_pam_log(LOG_DEBUG, "tac_service='%s'", tac_service);
Expand Down

0 comments on commit 4a9852c

Please sign in to comment.