Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPRIS supportedUriSchemes typo #178

Merged
merged 1 commit into from Jun 30, 2022
Merged

Fix MPRIS supportedUriSchemes typo #178

merged 1 commit into from Jun 30, 2022

Conversation

Notexe
Copy link
Contributor

@Notexe Notexe commented Jun 28, 2022

KDE Media Player's applet now picks up spotify-qt with this fix.

Current track info shows, next/previous/pause buttons work. Seems like there is an issue with trying to resume playback though but that is unrelated to this commit.

@kraxarn
Copy link
Owner

kraxarn commented Jun 30, 2022

Thank you very much for this! Maybe this issue can finally be resolved soon 😄

I'm also able to reproduce the issue related to resuming playback. Seems like spotify-qt reports the correct playback status, but it's still not detected properly. Skipping also doesn't seem to work. I'll look into it.

@kraxarn kraxarn added this to In progress in v3.9 via automation Jun 30, 2022
@Notexe
Copy link
Contributor Author

Notexe commented Jun 30, 2022

No problem. I was trying to figure out why KDE just wasn't picking it up at all so I started looking at the MPRIS specs and finally found the issue which happened to be that typo.

Skipping seems to work for me so that's very strange that it's not working for you. Hopefully it's something easy to fix at least.

Anyways thank you making this program 😄. It's much nicer to use compared to the official client which can't even be minimised to the tray which was the main reason I tried this out instead.

@kraxarn kraxarn merged commit a257225 into kraxarn:master Jun 30, 2022
v3.9 automation moved this from In progress to Done Jun 30, 2022
@kraxarn
Copy link
Owner

kraxarn commented Jul 1, 2022

Read a bit more about the specification, and realized you have to emit a PropertiesChanged event when the status changes for it to recognize it properly. Simply added a check for it (8bba9b7) and play/pause from mpris seems to work much better now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v3.9
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants