Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve quotes create form issue with custom attributes. #1192

Closed
wants to merge 1 commit into from
Closed

solve quotes create form issue with custom attributes. #1192

wants to merge 1 commit into from

Conversation

mohamedgouda98
Copy link

BUGS:

when create custom attribute related to quotes not displayed in create form

Otherwise use **issue #1190 ** .

@mohamedgouda98 mohamedgouda98 mentioned this pull request Jul 14, 2023
Closed
@prabhat-webkul
Copy link
Collaborator

@mohamedgouda98
Please add an accordion for custom attributes, and do the changes for the edit case.

You also need to modify the quotation PDF.

After these changes, I will review and merge them.

@prabhat-webkul
Copy link
Collaborator

@mohamedgouda98
instead of whereNotIn, please add a condition for custom attributes in that accordion

@prabhat-webkul
Copy link
Collaborator

fixed by #1231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohamedgouda98 @prabhat-webkul @devansh-webkul