Fix leak in ulog_replay()

ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller should not also do so. ticket: 8441 (new) target_version: 1.14-next target_version: 1.13-next tags: pullup
krb5 · Aug 10, 2016 · 2908839 · 2908839
1 parent 3e5f770
commit 2908839
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
@@ -414,10 +414,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
             if (retval)
                 goto cleanup;
         } else {
-            entry = k5alloc(sizeof(krb5_db_entry), &retval);
-            if (entry == NULL)
-                goto cleanup;
-
             retval = ulog_conv_2dbentry(context, &entry, upd);
             if (retval)
                 goto cleanup;