Skip to content

Commit

Permalink
Fix leak in FAST OTP client processing
Browse files Browse the repository at this point in the history
In set_pa_data(), after encoding the OTP request and stealing the
pointer from the resulting krb5_data object, free the krb5_data
container.

ticket: 8443 (new)
target_version: 1.14-next
target_version: 1.13-next
tags: pullup
  • Loading branch information
greghudson committed Aug 10, 2016
1 parent 0c5f74a commit 7029efc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/lib/krb5/krb/preauth_otp.c
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,7 @@ set_pa_data(const krb5_pa_otp_req *req, krb5_pa_data ***pa_data_out)
goto error;
out[0]->contents = (krb5_octet *)tmp->data;
out[0]->length = tmp->length;
free(tmp);

*pa_data_out = out;
return 0;
Expand Down

0 comments on commit 7029efc

Please sign in to comment.