Read /etc/gss/mech if no mech.d/*.conf found #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is permitted for glob() to return an error without having allocated/initialized gl_pathv, in which case the subsequent for loop will not have a proper termination condition. |
|
gd's patch had a memset for globbuf, which I think is adequate to address this. I added one into the patch. |
|
This doesn't really help, since gl_pathv is a pointer element of glob_t, so memset() just means that our assignment to gl_pathv[0] is a guaranteed NULL dereference in the case where glob() fails to allocate, as opposed to dereferencing stale register contents. |
|
Alright, new approach, giving up on GLOB_DOOFFS. |
Always read /etc/gss/mech, even if globbing /etc/gss/mech.d/*.conf doesn't work. Doing this using GLOB_DOOFFS proved error-prone, so use a simpler approach: factor out the per-pathname handling into a helper function load_if_changed, call it with MECH_CONF before the glob, then pass each glob result through the helper. ticket: 7925
|
Pushed to master as ac98187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this bug when integrating gd's patch. Here is a fix. I think pretty much everything that can go wrong with glob() should still result in trying to read /etc/gss/mech.