Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing salt from enctype in t_kdb.py test #226

Closed
wants to merge 1 commit into from

Conversation

pkis
Copy link

@pkis pkis commented Oct 24, 2014

kadmin requires enctypes in form "key:salt"
If it is not given in that form, it reports error and the test fails.

The issue might remain hidden because the test is executed only if ldap is installed. If missing, the test silently passes (only the verbose output shows more detail).

@greghudson
Copy link
Member

kadmin has allowed the salt to be omitted in keysalt lists since cc26d29 (RT #884). I am curious what circumstances led to running new t_kdb.py tests against an old version of kadmin.

@pkis
Copy link
Author

pkis commented Oct 29, 2014

Ah, this is my fault, sorry, I ran the test from 1.12-2, where the test t_kdb.py was failing and I did not check it in the latest version. Checking it again, the branch 1.12 contains the test t_kdb.py but is missing the fix from RT #884, so this is still a problem, but I obviously reported it against the wrong branch.
Ok, so the test in the master branch is working. The question is then, should this be reported against 1.12? Or better I should ask, does it make sense to report problems against 1.12 (are there plans to release 1.12-3)?

@greghudson
Copy link
Member

Thanks for the clarification. You appear to be right, and your patch looks like a correct fix for the problem. Tom can apply it to the 1.12 branch, and it will go into the 1.12.3 release whenever that comes out.

@tlyu
Copy link
Member

tlyu commented Feb 4, 2015

Thanks; pushed as 62a4509.

@tlyu tlyu closed this Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants