Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impersonate_name to work with interposers #348

Closed
wants to merge 1 commit into from

Conversation

simo5
Copy link
Contributor

@simo5 simo5 commented Nov 13, 2015

This follows the same modifications applied to gss_acquire_cred_with_pw
when interposer plugins were introduced.

Signed-off-by: Simo Sorce simo@redhat.com

@greghudson
Copy link
Member

Did you run the test suite on this? I get a failure in t_s4u.py.

@greghudson
Copy link
Member

Notes on what goes wrong in t_s4u.py:

  • At command 15, we run "./t_s4u p:user@KRBTEST.COM p:service/2@KRBTEST.COM". Everything works as expected: service/1 makes an S4U2Self request and gets a ticket from user to service/1, but it's not forwardable because service/1 doesn't have ok-to-auth-as-delegate set. So gss_accept_sec_context() doesn't produce a delegated cred and t_s4u doesn't try constrained delegation.
  • At command 16, we run the same command with the --spnego option. Something goes wrong in gss_acquire_cred_impersonate_name(), and the client winds up making a regular TGS request and getting tickets from service/1 to service/1. t_s4u tries constrained delegation with this evidence ticket and gets a NOT_ALLOWED_TO_DELEGATE error from the KDC.

@simo5
Copy link
Contributor Author

simo5 commented Nov 16, 2015

Sorry, I was testing with gssproxy's framework and did not actually run krb5's test suite, my bad.
I'll ping again once I have it fixed.

This follows the same modifications applied to gss_acquire_cred_with_pw
when interposer plugins were introduced.

Signed-off-by: Simo Sorce <simo@redhat.com>
@simo5
Copy link
Contributor Author

simo5 commented Nov 17, 2015

I pushed a new patch that fixes the issue with Spnego.
It simply does the same thing that's already done in acquire_cred_with_password

However I did not for see this issue when testing the interposer w/o SPNEGO, so please hold off merging until I am finished testing against the interposer code I have in gss-proxy.

@simo5
Copy link
Contributor Author

simo5 commented Nov 23, 2015

@greghudson fwiw I did test with krb5 but not spnego interpodsed by gssproxy, but that's fine as the interposer normally does not interpose spnego.
So if you agree with the patch here please feel free to merge.

@greghudson
Copy link
Member

Pushed to master as b3901af

@greghudson greghudson closed this Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants