Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix droparea being unresponsive on Firefox browsers #13

Closed
bearsy1 opened this issue Oct 1, 2022 · 6 comments · Fixed by #14
Closed

Fix droparea being unresponsive on Firefox browsers #13

bearsy1 opened this issue Oct 1, 2022 · 6 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@bearsy1
Copy link

bearsy1 commented Oct 1, 2022

I can't seem to be able to drag any item, whether from a compendium or from an imported item in the sidebar, to a token's loot list. When the cursor with an item is hovering over the drop area, it just shows the red circle-line symbol and nothing happens, no errors in the console and the list is not updated. I use tidysheet but I can't drag items with the default sheet either.

Is there something I'm missing (in terms of dependencies or steps to take for usage)?

Foundry 10.285 (Forge hosted)
DnD5e 2.0.3
Simple Loot List 10.0.4
Firefox 105.0.1 (64 bit)
& a bunch of other modules installed

@krbz999
Copy link
Owner

krbz999 commented Oct 1, 2022

The current Foundry version is 10.286, though I don't think it is relevant. Please try updating.

  • Then, could you try with all other modules disabled?
  • If the issue persists, try in a different browser.

I can't recreate any issue on Microsoft Edge (Foundry 10.286) on Forge - nor on a local install.

And no, the module does not have any dependencies. You simply drag an item into the droparea, as you say you have tried.

@bearsy1
Copy link
Author

bearsy1 commented Oct 1, 2022

I'll make a backup and try it again after updating. Fingers crossed!

@bearsy1
Copy link
Author

bearsy1 commented Oct 1, 2022

Update.

I updated foundry to 10.286 and disabled all other modules apart from of course Simple Loot List, using Firefox. Still didn't let me drag and drop items.

However, using Chrome (latest version) under the same setup (all other modules disabled), it all worked fine. Strange. What's more, I activated the plethora of modules in my regular setup, still in Chrome, and Simple Loot List still worked. It is indeed a browser issue.

I wonder why? I don't have strong feelings against other browsers, but I like and have gotten used to the feature set provided by firefox. I don't know if I'm asking for the moon here, but if it's not too much of a hassle, could this issue be addressed in this module with how it interacts with browsers (specifically being Firefox friendly)?

If not, that's okay too. If push comes to shove and I can come to terms with opening a different browser for my sessions, I might do just that (or give up on the idea of using your awesome module haha).

@krbz999
Copy link
Owner

krbz999 commented Oct 1, 2022

I think Chrome and Edge are the recommended browsers for Foundry.
However, I'll have a look at why this happens and see what can be done.

@krbz999 krbz999 added the bug Something isn't working label Oct 1, 2022
@krbz999 krbz999 changed the title Can't Drag Items to Loot List Fix droparea being unresponsive on Firefox browsers Oct 1, 2022
krbz999 added a commit that referenced this issue Oct 1, 2022
Fixes Firefox browsers (closes #13).
@krbz999 krbz999 mentioned this issue Oct 1, 2022
@krbz999
Copy link
Owner

krbz999 commented Oct 1, 2022

A release has been pushed. I tested on Firefox and was able to reproduce the issue, and confirm that it worked afterwards. Thank you for reporting it. Please re-open this issue (or a new one), if the 10.0.5 release does not fix it.

@bearsy1
Copy link
Author

bearsy1 commented Oct 1, 2022

Praise be! I don't know how you were able to get it sorted out so fast. Tried out the updated version and it works beautifully.
I wish I could develop modules like you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants