Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppCheck support #174

Merged
merged 3 commits into from Mar 30, 2023
Merged

Add AppCheck support #174

merged 3 commits into from Mar 30, 2023

Conversation

nhaynes
Copy link
Contributor

@nhaynes nhaynes commented Mar 30, 2023

Description

We added AppCheck to firebase-php library a little while back and we apparently updated the docs to reflect that it works with laravel-firebase but we never actually made the changes in this project.

Docs referencing the inclusion in laravel-firebase:
image

Fixes # 171

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #174 (162b3a5) into main (48b788c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #174      +/-   ##
============================================
+ Coverage     98.30%   98.38%   +0.08%     
- Complexity       44       46       +2     
============================================
  Files             3        3              
  Lines           118      124       +6     
============================================
+ Hits            116      122       +6     
  Misses            2        2              
Impacted Files Coverage Δ
src/FirebaseProject.php 100.00% <100.00%> (ø)
src/ServiceProvider.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeromegamez jeromegamez changed the title feat(app-check): added AppCheck to the ServiceProvider and Facade Add AppCheck support Mar 30, 2023
@jeromegamez jeromegamez merged commit 18d7ccc into kreait:main Mar 30, 2023
7 checks passed
@jeromegamez
Copy link
Member

Thank you, it's much appreciated! 🌺

You certainly have noticed that I squashed/rebased your MRs and Commits with different titles. I don't use conventional commits in my projects, and my commit messages are always in the present tense. You don't have to change this, I just wanted to explain why I do it 😅.

@nhaynes
Copy link
Contributor Author

nhaynes commented Mar 30, 2023

@jeromegamez I never used to use them either but then I found https://github.com/semantic-release/semantic-release and it convinced me to change my ways. I recommend giving it a go on a future project.

@nhaynes nhaynes deleted the add-app-check branch March 30, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants