Fix broken test for MutableSet.pop() (pythonGH-25209)

Changes the test to not assert concrete result of pop, but just that it was an item from the set, and that the set shrunk by one.
kreathon · May 2, 2021 · 5ec8a9a · 5ec8a9a
1 parent bbacaef
commit 5ec8a9a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py
@@ -1512,8 +1512,12 @@ def discard(self,v):
                 return result
             def __repr__(self):
                 return "MySet(%s)" % repr(list(self))
-        s = MySet([5,43,2,1])
-        self.assertEqual(s.pop(), 1)
+        items = [5,43,2,1]
+        s = MySet(items)
+        r = s.pop()
+        self.assertEquals(len(s), len(items) - 1)
+        self.assertNotIn(r, s)
+        self.assertIn(r, items)
 
     def test_issue8750(self):
         empty = WithSet()