Adopt DRY principle and enhance performance #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored
multiple-files.converter.ts
andsingle-file.converter.ts
to enhance DRY principle in the project.To read more about DRY: https://en.wikipedia.org/wiki/Don%27t_repeat_yourself
I've also introduced a major performance improvement by processing files in parallel using Promise.all instead of a linear approach.
I've performed a couple of tests with the old and new code and they are currently producing the same result. I recommend raising the Unit Tests coverage in order to enable project growth.