chore: replace more deprecated image latest attribute with id

kreuzwerker · Jun 14, 2021 · 3a6790c · 3a6790c
1 parent 58a5e85
commit 3a6790c
Show file tree

Hide file tree

Showing 17 changed files with 19 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -45,7 +45,7 @@ resource "docker_image" "nginx" {
 # -> same as 'docker run --name nginx -p8080:80 -d nginx:latest'
 resource "docker_container" "nginx" {
   name    = "nginx"
-  image   = docker_image.nginx.latest
+  image   = docker_image.nginx.id
 
   ports {
     external = 8080
@@ -59,7 +59,7 @@ resource "docker_service" "nginx_service" {
   name = "nginx-service"
   task_spec {
     container_spec {
-      image = docker_image.nginx.latest
+      image = docker_image.nginx.id
     }
   }
 

diff --git a/docs/index.md b/docs/index.md
@@ -41,7 +41,7 @@ resource "docker_image" "ubuntu" {
 
 # Create a container
 resource "docker_container" "foo" {
-  image = docker_image.ubuntu.latest
+  image = docker_image.ubuntu.id
   name  = "foo"
 }
 ```
@@ -61,7 +61,7 @@ resource "docker_image" "ubuntu" {
 
 # Create a container
 resource "docker_container" "foo" {
-  image = docker_image.ubuntu.latest
+  image = docker_image.ubuntu.id
   name  = "foo"
 }
 ```

diff --git a/docs/resources/container.md b/docs/resources/container.md
@@ -16,7 +16,7 @@ Manages the lifecycle of a Docker container.
 # Start a container
 resource "docker_container" "ubuntu" {
   name  = "foo"
-  image = docker_image.ubuntu.latest
+  image = docker_image.ubuntu.id
 }
 
 # Find the latest Ubuntu precise image.

diff --git a/examples/provider/provider-tf12.tf b/examples/provider/provider-tf12.tf
@@ -10,6 +10,6 @@ resource "docker_image" "ubuntu" {
 
 # Create a container
 resource "docker_container" "foo" {
-  image = docker_image.ubuntu.latest
+  image = docker_image.ubuntu.id
   name  = "foo"
 }
diff --git a/examples/provider/provider-tf13.tf b/examples/provider/provider-tf13.tf
@@ -18,6 +18,6 @@ resource "docker_image" "ubuntu" {
 
 # Create a container
 resource "docker_container" "foo" {
-  image = docker_image.ubuntu.latest
+  image = docker_image.ubuntu.id
   name  = "foo"
 }
diff --git a/examples/resources/docker_container/resource.tf b/examples/resources/docker_container/resource.tf
@@ -1,7 +1,7 @@
 # Start a container
 resource "docker_container" "ubuntu" {
   name  = "foo"
-  image = docker_image.ubuntu.latest
+  image = docker_image.ubuntu.id
 }
 
 # Find the latest Ubuntu precise image.

diff --git a/internal/provider/resource_docker_service_test.go b/internal/provider/resource_docker_service_test.go
@@ -1218,7 +1218,7 @@ const updateMultiplePropertiesConfigConverge = `
   
 	task_spec {
 	  container_spec {
-		image = data.docker_image.tftest_image.latest
+		image = data.docker_image.tftest_image.id
   
 		%s
   

diff --git a/testdata/resources/docker_container/testAccDockerContainerInitConfig.tf b/testdata/resources/docker_container/testAccDockerContainerInitConfig.tf
@@ -4,6 +4,6 @@ resource "docker_image" "fooinit" {
 
 resource "docker_container" "fooinit" {
   name  = "tf-test"
-  image = docker_image.fooinit.latest
+  image = docker_image.fooinit.id
   init  = true
 }
diff --git a/testdata/resources/docker_container/testAccDockerContainerMountsConfig.tf b/testdata/resources/docker_container/testAccDockerContainerMountsConfig.tf
@@ -8,7 +8,7 @@ resource "docker_volume" "foo_mounts" {
 
 resource "docker_container" "foo_mounts" {
   name  = "tf-test"
-  image = docker_image.foo_mounts.latest
+  image = docker_image.foo_mounts.id
 
   mounts {
     target    = "/mount/test"

diff --git a/testdata/resources/docker_service/testAccDockerServiceConvergeAndStopGracefully.tf b/testdata/resources/docker_service/testAccDockerServiceConvergeAndStopGracefully.tf
@@ -13,7 +13,7 @@ resource "docker_service" "foo" {
   name = "tftest-service-basic-converge"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
       healthcheck {
         test         = ["CMD", "curl", "-f", "localhost:8080/health"]

diff --git a/testdata/resources/docker_service/testAccDockerServiceFullSpec.tf b/testdata/resources/docker_service/testAccDockerServiceFullSpec.tf
@@ -38,7 +38,7 @@ resource "docker_service" "foo" {
 
   task_spec {
     container_spec {
-      image = docker_image.tftest_image.latest
+      image = docker_image.tftest_image.id
 
       labels {
         label = "foo"

diff --git a/testdata/resources/docker_service/testAccDockerServiceGlobalReplicationMode.tf b/testdata/resources/docker_service/testAccDockerServiceGlobalReplicationMode.tf
@@ -13,7 +13,7 @@ resource "docker_service" "foo" {
   name = "tftest-service-basic"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
     }
   }

diff --git a/testdata/resources/docker_service/testAccDockerServicePartialReplicationConfig.tf b/testdata/resources/docker_service/testAccDockerServicePartialReplicationConfig.tf
@@ -14,7 +14,7 @@ resource "docker_service" "foo" {
   name = "tftest-service-basic"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
     }
   }

diff --git a/testdata/resources/docker_service/testAccDockerServicePartialReplicationConfigStep2.tf b/testdata/resources/docker_service/testAccDockerServicePartialReplicationConfigStep2.tf
@@ -14,7 +14,7 @@ resource "docker_service" "foo" {
   name = "tftest-service-basic"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
     }
   }

diff --git a/testdata/resources/docker_service/testAccDockerServicePartialReplicationConfigStep3.tf b/testdata/resources/docker_service/testAccDockerServicePartialReplicationConfigStep3.tf
@@ -14,7 +14,7 @@ resource "docker_service" "foo" {
   name = "tftest-service-basic"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
     }
   }

diff --git a/testdata/resources/docker_service/testAccDockerServicePrivateImageConverge.tf b/testdata/resources/docker_service/testAccDockerServicePrivateImageConverge.tf
@@ -23,7 +23,7 @@ resource "docker_service" "foo" {
   name     = "tftest-service-foo"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
 
     }

diff --git a/testdata/resources/docker_service/updateFailsAndRollbackConvergeConfig.tf b/testdata/resources/docker_service/updateFailsAndRollbackConvergeConfig.tf
@@ -23,7 +23,7 @@ resource "docker_service" "foo" {
   name     = "tftest-service-updateFailsAndRollbackConverge"
   task_spec {
     container_spec {
-      image             = docker_image.tftest_image.latest
+      image             = docker_image.tftest_image.id
       stop_grace_period = "10s"
 
       healthcheck {