-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aux_address crash #8
Conversation
53dc8d7
to
bd18a1e
Compare
bd18a1e
to
c1524be
Compare
Basically, it looks good. |
Fixed. |
CI failed, but it seems to have nothing to do with this pull request. https://github.com/kreuzwerker/terraform-provider-docker/pull/8/checks?check_run_id=1484103804
|
Yeah, looks like it's about docs / website. @suzuki-shunsuke @mavogel is there a discord / slack for this project? |
Sorry but I don't know because recently I became a collaborator. I have confirmed the crash is solved by this pull request.
|
@mavogel Can I merge this pull request? |
@dubo-dubon-duponey I just created one at gophers.slack.com -> #terraform-provider-docker
Feel free to merge yes. If you think you need an additional review add me. |
I will happily continue reporting and triaging issues, and submitting small fixes for my own pet bugs ;-). It's hard to formerly commit being available beyond that though, but yeah, happy to chip in... |
Thank you for your contribution! |
@mavogel fixes #7
I'm not completely sure about this so... PTAL and let me know if this is the right approach.