Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aux_address crash #8

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

dubo-dubon-duponey
Copy link
Contributor

@mavogel fixes #7

I'm not completely sure about this so... PTAL and let me know if this is the right approach.

Signed-off-by: dubo-dubon-duponey <dubodubonduponey+github@pm.me>
@suzuki-shunsuke
Copy link
Collaborator

Basically, it looks good.
I add a small suggestion. #8 (comment)

@dubo-dubon-duponey
Copy link
Contributor Author

Basically, it looks good.
I add a small suggestion. #8 (comment)

Fixed.
Thanks a lot for the help.

@suzuki-shunsuke
Copy link
Collaborator

CI failed, but it seems to have nothing to do with this pull request.

https://github.com/kreuzwerker/terraform-provider-docker/pull/8/checks?check_run_id=1484103804

/go/src/github.com/hashicorp/terraform-website/content/scripts/check-links.sh "http://127.0.0.1:4567/docs/providers/docker/"
Crawling site...
http://127.0.0.1:4567/docs/providers/docker/:
Remote file does not exist -- broken link!!!
Found 1 broken link.

http://127.0.0.1:4567/docs/providers/docker/

make[1]: *** [website-provider-test] Error 8
Makefile:85: recipe for target 'website-provider-test' failed
make[1]: Leaving directory '/go/src/github.com/hashicorp/terraform-website'
GNUmakefile:64: recipe for target 'website-test' failed
make: *** [website-test] Error 2
Error: Process completed with exit code 2.

@dubo-dubon-duponey
Copy link
Contributor Author

dubo-dubon-duponey commented Dec 2, 2020

CI failed, but it seems to have nothing to do with this pull request.

Yeah, looks like it's about docs / website.

@suzuki-shunsuke @mavogel is there a discord / slack for this project?

@suzuki-shunsuke
Copy link
Collaborator

suzuki-shunsuke mavogel is there a discord / slack for this project?

Sorry but I don't know because recently I became a collaborator.


I have confirmed the crash is solved by this pull request.

$ terraform apply                                                                                                                                    

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # docker_network.vlan will be created
  + resource "docker_network" "vlan" {
      + driver      = (known after apply)
      + id          = (known after apply)
      + internal    = (known after apply)
      + ipam_driver = "default"
      + name        = "pr-8"
      + options     = (known after apply)
      + scope       = (known after apply)

      + ipam_config {
          + aux_address = {
              + "foo" = "192.168.1.5"
            }
          + subnet      = "192.168.0.0/16"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

docker_network.vlan: Creating...
docker_network.vlan: Creation complete after 2s [id=227b69944c4ddb549245f305206a7e3a76ba18af8f1eaa0077f893f3850a4020]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

@suzuki-shunsuke
Copy link
Collaborator

@mavogel Can I merge this pull request?
I became a collaborator and have a permission to merge the pull request,
but I don't know the role which I'm expected and the rule of this repository yet.

@mavogel
Copy link
Contributor

mavogel commented Dec 3, 2020

@dubo-dubon-duponey I just created one at gophers.slack.com -> #terraform-provider-docker
Maybe you're also interested in maintaining and helping us distribute the work on more shoulders. That would be awesome.

@suzuki-shunsuke

I became a collaborator and have a permission to merge the pull request,
but I don't know the role which I'm expected and the rule of this repository yet.

Feel free to merge yes. If you think you need an additional review add me.

@dubo-dubon-duponey
Copy link
Contributor Author

@dubo-dubon-duponey I just created one at gophers.slack.com -> #terraform-provider-docker
Maybe you're also interested in maintaining and helping us distribute the work on more shoulders. That would be awesome.

I will happily continue reporting and triaging issues, and submitting small fixes for my own pet bugs ;-).

It's hard to formerly commit being available beyond that though, but yeah, happy to chip in...

@suzuki-shunsuke
Copy link
Collaborator

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke merged commit dec6232 into kreuzwerker:master Dec 4, 2020
@mavogel mavogel added this to the v2.9.0 milestone Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crash when using docker_network with aux_address = {foo: ip}
3 participants