This repository has been archived by the owner on Jul 8, 2023. It is now read-only.
Theme support #14
Closed
Theme support #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added folder Themes containing lightbox.css files for every theme and a image folder for custom buttons (aka other colors). Removed the loading image and close button from the javascript code. These should be added through CSS since they are depending on the theme. Signed-off-by: Herman <hermanbanken@gmail.com>
The Theme support comes from the Wordpress Stimuli Lightbox plugin. So in order to make the css work I had to remove all the stimuli_ prefixes and do some other little tweaking. Signed-off-by: Herman <hermanbanken@gmail.com>
Patched White, Grey and Dark Grey Signed-off-by: Herman <hermanbanken@gmail.com>
Signed-off-by: Herman <hermanbanken@gmail.com>
You can now choose a theme on the demo page, live. Signed-off-by: Herman <hermanbanken@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Krewenki,
I've added theme support in my version of jquery-lightbox. To do this I only changed the js file in 2 places and added 1 directory with Themes. The js changes:
This way all images are referenced from CSS and users can quickly change the file by editing/swapping it in the Themes directory.
I compared your lightbox.css to mine and added all necessary things mine didn't include. I haven't yet looked at CSS markup. I noticed you add a tab before the closing curly-bracket?
I feel this branch could be usefull for many people, so please consider a pull.
Greetings from the Netherlands,
Herman