Skip to content

Commit

Permalink
Handle translated combobox models better
Browse files Browse the repository at this point in the history
Make gtk-builder-convert keep translated combobox models translated.
Fixes bug 553385.
  • Loading branch information
Matthias Clasen committed May 4, 2009
1 parent 3dc395a commit 7f6a534
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion gtk/gtk-builder-convert
Expand Up @@ -546,6 +546,14 @@ class GtkBuilderConverter(object):
if not prop.childNodes:
parent.removeChild(prop)
return

translatable_attr = prop.attributes.get('translatable')
translatable = translatable_attr is not None and translatable_attr.value == 'yes'
has_context_attr = prop.attributes.get('context')
has_context = has_context_attr is not None and has_context_attr.value == 'yes'
comments_attr = prop.attributes.get('comments')
comments = comments_attr is not None and comments_attr.value or None

value = prop.childNodes[0].data
model = self._create_root_object("GtkListStore",
template="model")
Expand All @@ -568,7 +576,15 @@ class GtkBuilderConverter(object):

col = self._dom.createElement('col')
col.setAttribute('id', '0')
col.setAttribute('translatable', 'yes')
if translatable:
col.setAttribute('translatable', 'yes')
if has_context:
splitting = item.split('|', 1)
if len(splitting) == 2:
context, item = splitting
col.setAttribute('context', context)
if comments is not None:
col.setAttribute('comments', comments)
col.appendChild(self._dom.createTextNode(item))
row.appendChild(col)

Expand Down

0 comments on commit 7f6a534

Please sign in to comment.