Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React 15.5.0 #89

Closed
plemarquand opened this issue Apr 13, 2017 · 1 comment
Closed

Support React 15.5.0 #89

plemarquand opened this issue Apr 13, 2017 · 1 comment

Comments

@plemarquand
Copy link
Contributor

plemarquand commented Apr 13, 2017 •
edited by koistya

React 15.5.0 issues a warning that PropTypes and React.createClass should be pulled from separate dependencies instead of being imported from React itself (React.createClass is only used in the tests). This warning is in anticipation of React 16 which will remove them all together.

To fix, remove imports of PropTypes from react and import it instead from the prop-types package. Also import createClass from the create-react-class package instead of react.
plemarquand pushed a commit to plemarquand/isomorphic-style-loader that referenced this issue Apr 13, 2017
Fixes for React 15.5.0
d59481b 
- Pull PropTypes from prop-types package
- Use createClass from create-react-class

Fixes kriasoft#89
@plemarquand plemarquand mentioned this issue Apr 13, 2017
Merged
koistya pushed a commit that referenced this issue Apr 14, 2017
@plemarquand @koistya
Fixes for React 15.5.0 (#90)
f2fc85e 
- Pull PropTypes from prop-types package
- Use createClass from create-react-class

Fixes #89
@4refr0nt
Copy link

Please, increment version number for upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@4refr0nt @plemarquand