Pure Apollo integration based on master
#1664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piglovesyou
force-pushed
the
feature/apollo-pure
branch
6 times, most recently
from
24e02f8
to
5ef8174
Compare
- [x] `apollo-client` with full server-side rendering - [x] `apollo-link-state` - Client-side state management with `networkStatus` example - [x] `apollo-server` Without: * Flux (Redux) store - replaced by `apollo-link-state` * Fetch function - No need when you have an `apolloClient`
piglovesyou
force-pushed
the
feature/apollo-pure
branch
from
bc9958a
to
a1dc543
Compare
5 tasks
|
Hi! Great work, I will review it in my rare free time 🙂 Please remind me in few days if I forget to do it 😉 |
|
@langpavel Thank you for your support. I did on #1665 . |
|
Your work is now pushed in |
langpavel
added
duplicate
branch master
branch feature/apollo-pure
and removed
TRACKING
branch feature/apollo
example
labels
|
@langpavel Wow, pleasure, thanks. Then shall I delete this PR? Further commits and discussion seem to go in #1666. |
|
Don't delete this PR, you can push fresh commits here. |
|
All right. I'll push another to it when I feel like it. |
piglovesyou
force-pushed
the
feature/apollo-pure
branch
from
49bfabe
to
787bbed
Compare
|
@langpavel I have a question. When I'd like to update |
|
Sorry I missed your previous comment, I'll create a PR pointing to |
* Upgrade all dependencies 1. ncu --upgradeAll 4. Leave "graphql" to be "^13.2.0" that apollo packages depend on 2. Apply patch of "npx babel-upgrade" output 3. Leave only necessary babel plugins 4. Pass "yarn fix" by disabling stricter rules * Pass "req" through GraphQL resolver context * Through rootValue it cannot be passed from browser GraphQL access * rm unnecessary code * Add "Timestamp" scalar type for convinience * rm unnecessary files * fix: Timestamp didn't work * npm graphql requires to be update vercel/next.js#5238 (comment) * Feature: Codegen from GraphQL schema and use more Flow types (#2) * install apllo * add apollo.config.js * apollo codegen succeeded * fix: updateNetworkStatus signature * rm @flow from files not ready * add flow-typed files * done: Using auto-generated types works * flow-bin@0.89+ has regression. Use ^0.88.0. * fix: invalid GraphQL primitive types * Add codegen script * done: import auto-generated file * refac: move impl for apollo-link-state to graphql dir as same as server side resolvers * codegen and ignore eslint these files * refactor: "networkStatus" * feat: codegen:standalone * refac: "OnMemoryState" is what I meant * Improve codegen (#3) * delete existing auto-generated types * change script name * ignore __generated__ folder * wip: disallow absolute path resolving under `src` dir * It causes disregard .js type checking under src * fix all flow error * modify: prevent `withStyles` drops component type * Modify targe Node versions * Fix build failure: Codegen before lint * Add Node v10 LTS for build target
piglovesyou
force-pushed
the
feature/apollo-pure
branch
from
a99f62d
to
c15b123
Compare
piglovesyou
force-pushed
the
feature/apollo-pure
branch
from
deb0578
to
27ba7d3
Compare
* small README.md grammar change (kriasoft#1675) * Upgrade all dependencies including Babel 7 (kriasoft#1673) * Upgrade all dependencies including Babel 7 1. ncu --upgradeAll 4. Leave "graphql" to be "^13.2.0" that apollo packages depend on 2. Apply patch of "npx babel-upgrade" output 3. Leave only necessary babel plugins 4. Pass "yarn fix" by disabling stricter rules fixes kriasoft#1654 kriasoft#1626 kriasoft#1607 * Also ignore babel config file from webpack.config.js * Resolve conflict and follow upstream/master * small README.md grammar change (kriasoft#1675) * Upgrade all dependencies including Babel 7 (kriasoft#1673) * Upgrade all dependencies including Babel 7 * update apollo packages * Use new local state management of Apollo Client 2.5 * Client Schema * Simplify cache and cache defaults * User in local state instead of context * bye apollo-link-state * mod: better suppressing flow error for .graphql import * fix: jest error by updating jest * Upgrade all dependencies fix 2 breaking changes: * css-loader no longer accepts 'minimize' option * isomorphic-style-loader uses new React Context now * refac: Use functional component for components * fix: resolve apollo and graphql versions problem ref. apollographql/apollo-tooling#630 (comment)
piglovesyou
force-pushed
the
feature/apollo-pure
branch
from
87fca22
to
dced0fa
Compare
piglovesyou
force-pushed
the
feature/apollo-pure
branch
from
9a2f3eb
to
6d98c30
Compare
improve eslint defs
* Sqlite3 is still working on supporting Node12 TryGhost/node-sqlite3#1151
|
I think I can close this PR now. I'll keep maintaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure Apollo integration based on
master.Features
apollo-clientwith full server-side rendering - Nofetch()apollo-client@2.5withnetworkStatusexampleapollo-serverserves GraphQL APITimestampfor an exampleBranches