Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TypeScript and other improvements on feature/apollo-pure #1723

Merged
merged 18 commits into from
May 27, 2019
Merged

Use TypeScript and other improvements on feature/apollo-pure #1723

merged 18 commits into from
May 27, 2019

Conversation

piglovesyou
Copy link
Collaborator

  • TypeScript support and non-typed module declaration
  • Make codegen always able to run
  • Use default client state management in apollo-client and remove apollo-link-state
  • refac: make all components functional

@piglovesyou piglovesyou changed the title Use TypeScript and other improvements wip: Use TypeScript and other improvements Apr 9, 2019
@piglovesyou piglovesyou changed the title wip: Use TypeScript and other improvements Use TypeScript and other improvements Apr 9, 2019
@piglovesyou
Copy link
Collaborator Author

@langpavel I turned it to TypeScript. Glad if you take a look.

@langpavel
Copy link
Collaborator

I'm out of time this week, please, remind me if I forget :-) Thanks!
BTW If you wish help with universal-router, here is my PR: kriasoft/universal-router#166

@piglovesyou
Copy link
Collaborator Author

piglovesyou commented Apr 10, 2019 •
edited

TS universal-router

Cool. I'll use your types after it's merged and released.

@piglovesyou
mod: clear old type defs before codegen
7f19a67 
improve eslint defs
@piglovesyou
ignore Node12 build
825af50 
* Sqlite3 is still working on supporting Node12 TryGhost/node-sqlite3#1151
@piglovesyou
Copy link
Collaborator Author

@langpavel Ready. Glad if you take time.

@piglovesyou piglovesyou changed the title Use TypeScript and other improvements Use TypeScript and other improvements on feature/apollo-pure May 6, 2019
@langpavel langpavel merged commit 27035c7 into kriasoft:feature/apollo-pure May 27, 2019
@piglovesyou
Copy link
Collaborator Author

Thank you Pavel!

@piglovesyou piglovesyou deleted the feature/apollo-pure branch June 21, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piglovesyou @langpavel