Add react-router #21
Closed
Add react-router #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koistya
force-pushed
the
master
branch
3 times, most recently
from
055a889
to
cd8225f
Compare
|
love this PR. @jakecraige mind resolving the conflicts if you have time? |
|
If there aren't any other large commits landing any time soon I'll rebase this and fix all merge conflicts. |
|
One thing to consider: currently there is a global handler listening for |
|
I'm not currently doing anything with react so I'd love for someone to take this over if they feel so inclined. @goatslacker ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20
Since I already did this when playing around I figured I'd just submit the PR prior to discussion