Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TypeScript to 4.9.5, fix types and build #215

Merged
merged 1 commit into from Jun 15, 2023

Conversation

mastahdocent
Copy link
Contributor

Currently universal-router breaks projects that use TypeScript 4.8 and greater. This PR fixes these issues.

@mastahdocent mastahdocent force-pushed the chore/update-ts branch 2 times, most recently from 8a35f8e to 4c06ead Compare June 14, 2023 15:03
@mastahdocent
Copy link
Contributor Author

@koistya thanks for letting this run, I fixed package-lock.json and it should work fine now :) Hope we can merge this soon :)

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ebdd25) 100.00% compared to head (e17a823) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          229       229           
  Branches        66        66           
=========================================
  Hits           229       229           
Impacted Files Coverage Δ
src/UniversalRouter.ts 100.00% <ø> (ø)
src/UniversalRouterSync.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koistya koistya merged commit db8a409 into kriasoft:main Jun 15, 2023
4 checks passed
@koistya koistya requested a review from frenzzy June 15, 2023 12:48
@mastahdocent
Copy link
Contributor Author

Hi, any chance for release to NPM? :) Thanks!

@koistya
Copy link
Member

koistya commented Jun 23, 2023

@mastahdocent done, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants