Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: _malloc errors when building with emscripten 2.0.4 #335

Merged
merged 1 commit into from Sep 16, 2020

Conversation

ianpurvis
Copy link
Collaborator

Fixes compound shape test errors

  Fixes 'b._malloc is not a function' when building with emscripten 2.0.4
@ianpurvis
Copy link
Collaborator Author

@kripken Hi... I accidentally caught this issue while testing a PR in my fork. Since CI always rolls with latest emscripten, I am thinking about how to better catch configuration breakage like this. A nightly heartbeat build with ubuntu?

> AMMO_PATH=builds/ammo.js ava


  compoundShape › compound shape

  tests/compoundShape.js:69

   68:   // Create convex hull shape                        
   69:   var convexHullShape = new Ammo.btConvexHullShape();
   70:   vec.setValue(1, 1, 1);                             

  Error thrown in test:

  TypeError {
    message: 'b._malloc is not a function',
  }

  › cB (builds/ammo.js:514:417)
  › new cC (builds/ammo.js:656:342)
  › tests/compoundShape.js:69:25

  ─

  1 test failed

@kripken
Copy link
Owner

kripken commented Sep 16, 2020

If it's easy to set up more testing that might help. But not sure it's worth it - this will be pretty rare, and not the end of the world if we notice it the next time we happen to run CI, I think.

@ianpurvis
Copy link
Collaborator Author

That's a good point... let's leave as is unless we reach enough issue to escalate it. 👍

@ianpurvis ianpurvis merged commit a4bec93 into kripken:master Sep 16, 2020
@ianpurvis ianpurvis deleted the fix/_malloc-is-not-a-function branch September 16, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants