Skip to content

Commit

Permalink
Extend the glUniform*fv upload functions to reuse the preallocated ty…
Browse files Browse the repository at this point in the history 
…ped array view objects for more than one uniform. This has been observed to improve performance in practice in an UE4 exported demo, where it reduced per frame CPU side time by ~-10%.
  • Loading branch information
@juj
juj committed Feb 29, 2016
1 parent 81bb6af commit 2c6e2a7
Showing 1 changed file with 148 additions and 68 deletions.
216 changes: 148 additions & 68 deletions src/library_gl.js
View file
Expand Up @@ -91,7 +91,7 @@ var LibraryGL = {
},

// Mini temp buffer
MINI_TEMP_BUFFER_SIZE: 16,
MINI_TEMP_BUFFER_SIZE: 256,
miniTempBuffer: null,
miniTempBufferViews: [0], // index i has the view of size i+1

Expand Down Expand Up @@ -2528,10 +2528,12 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform
view = GL.miniTempBufferViews[0];
view[0] = {{{ makeGetValue('value', '0', 'float') }}};
if (count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[count-1];
for(var i = 0; i < count; ++i) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*4') }}};
#if USE_PTHREADS
Expand All @@ -2549,11 +2551,13 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform
view = GL.miniTempBufferViews[1];
view[0] = {{{ makeGetValue('value', '0', 'float') }}};
view[1] = {{{ makeGetValue('value', '4', 'float') }}};
if (2*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[2*count-1];
for(var i = 0; i < 2*count; i += 2) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*8') }}};
#if USE_PTHREADS
Expand All @@ -2571,12 +2575,14 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform
view = GL.miniTempBufferViews[2];
view[0] = {{{ makeGetValue('value', '0', 'float') }}};
view[1] = {{{ makeGetValue('value', '4', 'float') }}};
view[2] = {{{ makeGetValue('value', '8', 'float') }}};
if (3*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[3*count-1];
for(var i = 0; i < 3*count; i += 3) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*12') }}};
#if USE_PTHREADS
Expand All @@ -2594,13 +2600,15 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform
view = GL.miniTempBufferViews[3];
view[0] = {{{ makeGetValue('value', '0', 'float') }}};
view[1] = {{{ makeGetValue('value', '4', 'float') }}};
view[2] = {{{ makeGetValue('value', '8', 'float') }}};
view[3] = {{{ makeGetValue('value', '12', 'float') }}};
if (4*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[4*count-1];
for(var i = 0; i < 4*count; i += 4) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*16') }}};
#if USE_PTHREADS
Expand Down Expand Up @@ -2715,11 +2723,14 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[3];
for (var i = 0; i < 4; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (4*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[4*count-1];
for(var i = 0; i < 4*count; i += 4) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*16') }}};
Expand All @@ -2738,11 +2749,19 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[8];
for (var i = 0; i < 9; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (9*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[9*count-1];
for(var i = 0; i < 9*count; i += 9) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
view[i+6] = {{{ makeGetValue('value', '4*i+24', 'float') }}};
view[i+7] = {{{ makeGetValue('value', '4*i+28', 'float') }}};
view[i+8] = {{{ makeGetValue('value', '4*i+32', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*36') }}};
Expand All @@ -2761,11 +2780,26 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[15];
for (var i = 0; i < 16; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (16*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[16*count-1];
for(var i = 0; i < 16*count; i += 16) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
view[i+6] = {{{ makeGetValue('value', '4*i+24', 'float') }}};
view[i+7] = {{{ makeGetValue('value', '4*i+28', 'float') }}};
view[i+8] = {{{ makeGetValue('value', '4*i+32', 'float') }}};
view[i+9] = {{{ makeGetValue('value', '4*i+36', 'float') }}};
view[i+10] = {{{ makeGetValue('value', '4*i+40', 'float') }}};
view[i+11] = {{{ makeGetValue('value', '4*i+44', 'float') }}};
view[i+12] = {{{ makeGetValue('value', '4*i+48', 'float') }}};
view[i+13] = {{{ makeGetValue('value', '4*i+52', 'float') }}};
view[i+14] = {{{ makeGetValue('value', '4*i+56', 'float') }}};
view[i+15] = {{{ makeGetValue('value', '4*i+60', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*64') }}};
Expand All @@ -2785,11 +2819,16 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[5];
for (var i = 0; i < 6; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (6*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[6*count-1];
for(var i = 0; i < 6*count; i += 6) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*24') }}};
Expand All @@ -2808,11 +2847,16 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[5];
for (var i = 0; i < 6; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (6*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[6*count-1];
for(var i = 0; i < 6*count; i += 6) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*24') }}};
Expand All @@ -2831,11 +2875,18 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[7];
for (var i = 0; i < 8; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (8*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[8*count-1];
for(var i = 0; i < 8*count; i += 8) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
view[i+6] = {{{ makeGetValue('value', '4*i+24', 'float') }}};
view[i+7] = {{{ makeGetValue('value', '4*i+28', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*32') }}};
Expand All @@ -2854,11 +2905,18 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[7];
for (var i = 0; i < 8; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (8*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[8*count-1];
for(var i = 0; i < 8*count; i += 8) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
view[i+6] = {{{ makeGetValue('value', '4*i+24', 'float') }}};
view[i+7] = {{{ makeGetValue('value', '4*i+28', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*32') }}};
Expand All @@ -2877,11 +2935,22 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[11];
for (var i = 0; i < 12; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (12*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[12*count-1];
for(var i = 0; i < 12*count; i += 12) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
view[i+6] = {{{ makeGetValue('value', '4*i+24', 'float') }}};
view[i+7] = {{{ makeGetValue('value', '4*i+28', 'float') }}};
view[i+8] = {{{ makeGetValue('value', '4*i+32', 'float') }}};
view[i+9] = {{{ makeGetValue('value', '4*i+36', 'float') }}};
view[i+10] = {{{ makeGetValue('value', '4*i+40', 'float') }}};
view[i+11] = {{{ makeGetValue('value', '4*i+44', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*48') }}};
Expand All @@ -2900,11 +2969,22 @@ var LibraryGL = {
#endif
location = GL.uniforms[location];
var view;
if (count === 1) {
// avoid allocation for the common case of uploading one uniform matrix
view = GL.miniTempBufferViews[11];
for (var i = 0; i < 12; i++) {
view[i] = {{{ makeGetValue('value', 'i*4', 'float') }}};
if (12*count <= GL.MINI_TEMP_BUFFER_SIZE) {
// avoid allocation when uploading few enough uniforms
view = GL.miniTempBufferViews[12*count-1];
for(var i = 0; i < 12*count; i += 12) {
view[i] = {{{ makeGetValue('value', '4*i', 'float') }}};
view[i+1] = {{{ makeGetValue('value', '4*i+4', 'float') }}};
view[i+2] = {{{ makeGetValue('value', '4*i+8', 'float') }}};
view[i+3] = {{{ makeGetValue('value', '4*i+12', 'float') }}};
view[i+4] = {{{ makeGetValue('value', '4*i+16', 'float') }}};
view[i+5] = {{{ makeGetValue('value', '4*i+20', 'float') }}};
view[i+6] = {{{ makeGetValue('value', '4*i+24', 'float') }}};
view[i+7] = {{{ makeGetValue('value', '4*i+28', 'float') }}};
view[i+8] = {{{ makeGetValue('value', '4*i+32', 'float') }}};
view[i+9] = {{{ makeGetValue('value', '4*i+36', 'float') }}};
view[i+10] = {{{ makeGetValue('value', '4*i+40', 'float') }}};
view[i+11] = {{{ makeGetValue('value', '4*i+44', 'float') }}};
}
} else {
view = {{{ makeHEAPView('F32', 'value', 'value+count*48') }}};
Expand Down

0 comments on commit 2c6e2a7

Please sign in to comment.