Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy File System and Closure: length is reported as zero #3842

Closed
fzimmermann89 opened this issue Oct 9, 2015 · 0 comments
Closed

Lazy File System and Closure: length is reported as zero #3842

fzimmermann89 opened this issue Oct 9, 2015 · 0 comments

Comments

@fzimmermann89
Copy link
Contributor

Hi,

there seems to be another bug in libary_fs's lazy filesystem implementation:
Problem: When using closure the length of lazy loaded files is reported as zero.
Reason: Object.defineProperty(lazyArray, "length") https://github.com/kripken/emscripten/blob/incoming/src/library_fs.js#L1650

The property is created from a string name, which closure won't changed, but is later used as .length (which is changed)

Might be reasonable to fix it along with #3837 (and maybe other bugs in the lazy filesystem as they turn up during the next week..)

-Felix

fzimmermann89 added a commit to fzimmermann89/emscripten that referenced this issue Oct 27, 2015
fixes emscripten-core#3842 by using Object.defineProperties instead of defineProperty.
fzimmermann89 added a commit to fzimmermann89/emscripten that referenced this issue Oct 27, 2015
fixes emscripten-core#3842 by using Object.defineProperties instead of defineProperty.
fzimmermann89 added a commit to fzimmermann89/emscripten that referenced this issue Oct 29, 2015
fixes emscripten-core#3842 by using Object.defineProperties instead of defineProperty.
fzimmermann89 added a commit to fzimmermann89/emscripten that referenced this issue Oct 29, 2015
fixes emscripten-core#3842 by using Object.defineProperties instead of defineProperty.
fzimmermann89 added a commit to fzimmermann89/emscripten that referenced this issue Oct 30, 2015
fixes emscripten-core#3842 by using Object.defineProperties instead of defineProperty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant