Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.asm.js file emitted with -s WASM=1 is not minified at all #5271

Closed
saschanaz opened this issue Jun 2, 2017 · 4 comments
Closed

.asm.js file emitted with -s WASM=1 is not minified at all #5271

saschanaz opened this issue Jun 2, 2017 · 4 comments
Labels

Comments

@saschanaz
Copy link
Collaborator

Compiling with -s WASM=1 -s BINARYEN_METHOD='native-wasm,asmjs' emits asm.js file with no minification even with -O2. It should be minified somehow.

@kripken
Copy link
Member

kripken commented Jun 3, 2017

This hasn't been a priority since such a build is a compromise build anyhow, so it's not fully optimized. It's useful mainly for debugging.

@saschanaz
Copy link
Collaborator Author

I want to use it as an automatic fallback on earlier browsers (including MSEdge 15 😅). My makefile already has been generating a compromise build because of -s ALLOW_MEMORY_GROWTH=1 so I don't bother with it.

@kripken
Copy link
Member

kripken commented Jun 5, 2017

I see. Seems reasonable to do this I guess.

We should probably show a warning at compile time though, in addition to the documentation, about the downsides of compromise builds.

@stale
Copy link

stale bot commented Aug 30, 2019

This issue has been automatically marked as stale because there has been no activity in the past 2 years. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Aug 30, 2019
@stale stale bot closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants