Misc SDL fixes #1264
Merged
Misc SDL fixes #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,6 +362,9 @@ var LibrarySDL = { | |||
| }, | |||
|
|
|||
| receiveEvent: function(event) { | |||
| if (event.preventDefault) { | |||
| event.preventDefault(); // disable default processing (browser back on backspace, etc.) | |||
There was a problem hiding this comment.
We do return false to achieve what I think is the same thing?
Except we return true in unload, to not prevent tabs from closing.
- Added misc SDL functions (SDL_GetKeyName, SDL_GetAppState, SDL_SetGammaRamp) - Added modifiers to test_sdl_key
|
The return false convention only works when assigning directly to the on[event] property (I put up an example here: http://www.inolen.com/events.html). However, I missed the unload event not needing to prevent the default action. I fixed that and cleaned up the unnecessary boolean return values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the changes in the commit message, I also converted the various document event handlers over to using addEventListener as opposed to assigning directly to the on[event] property.
While I'm not relying on this anymore, I believe at the time I was experimenting with some event binding in my shell that I didn't want to be inadvertently hulk-smashed by the SDL layer's event binding.