Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update binaryen port to 18 #4674

Merged
merged 1 commit into from Oct 28, 2016
Merged

Update binaryen port to 18 #4674

merged 1 commit into from Oct 28, 2016

Conversation

kripken
Copy link
Member

@kripken kripken commented Oct 28, 2016

Brings in 0xd support plus some optimizations.

@dschuff
Copy link
Member

dschuff commented Oct 28, 2016

Is it worth updating wasm.js to get the optimizer improvements?

@kripken
Copy link
Member Author

kripken commented Oct 28, 2016

I believe we don't run opts in the compiled interpreter in wasm.js (which makes sense, interpreted is slow anyhow).

@kripken
Copy link
Member Author

kripken commented Oct 28, 2016

Yeah, we don't, wasm.js doesn't even bother to link them in.

@kripken kripken merged commit 4c6654a into incoming Oct 28, 2016
@kripken kripken deleted the binaryen branch October 28, 2016 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kripken @dschuff