Simplfy memory growth code for polyfill interpreter #5173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to remove the duplicate code in wasm-js.cpp in Binaryen.
|
Unfortunately I don't see a good way to get rid of the call into |
kripken
reviewed
Apr 29, 2017
| @@ -2381,22 +2381,29 @@ function integrateWasmJS(Module) { | |||
| if (Module["usingWasm"]) { | |||
| try { | |||
| var result = Module['wasmMemory'].grow((size - oldSize) / wasmPageSize); // .grow() takes a delta compared to the previous size | |||
| if (result !== (-1 | 0)) { | |||
There was a problem hiding this comment.
don't we still need this code? it checks if grow failed.
kripken
reviewed
Apr 29, 2017
| exports['__growWasmMemory']((size - oldSize) / wasmPageSize); // tiny wasm method that just does grow_memory | ||
| // in interpreter, we replace Module.buffer if we allocate | ||
| return Module['buffer'] !== old ? Module['buffer'] : null; // if it was reallocated, it changed | ||
| // This path is only used by the polyfill interpreter. |
There was a problem hiding this comment.
i don't understand what this change does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to remove the duplicate code in wasm-js.cpp in Binaryen.