Warn when async wasm compilation is disabled #5497
Conversation
| logging.warning('BINARYEN_ASYNC_COMPILATION requested, but disabled since not in wasm-only mode') | ||
| logging.warning('BINARYEN_ASYNC_COMPILATION requested, but disabled because of user options. ' + warning) | ||
| elif 'BINARYEN_ASYNC_COMPILATION=0' not in settings_changes: | ||
| logging.warning('BINARYEN_ASYNC_COMPILATION disabled due to user options. ' + warning) |
There was a problem hiding this comment.
Can't the warning just say that it's because of the selected BINARYEN_METHOD? It looks like that's the only condition.
There was a problem hiding this comment.
It's a little more complicated, any time we are not in wasm-only mode then this happens. For example, if we use the asm.js optimizer (for something like safe-heap, emterpreter, outlining, or other such things built on the asm.js optimizer) then we are not in wasm-only mode.
(With some work perhaps those options could still use async compilation even without wasm-only mode, but I'm not sure how much. Also not sure how high a priority that should be.)
There was a problem hiding this comment.
Hm, ok. but it would still be nice if we could come up with a warning a little more actionable than "play around with random settings and see if the warning goes away". I don't really have any ideas right now though.
There was a problem hiding this comment.
Yeah, it would be better to be much more granular. But the link to the wiki page in the error here should help. And I think there will be churn here with options moving to support async compilation, so I'd rather not hardcode a list that could get out of date.
I could be wrong though and we'll see users say this isn't a good enough warning, we can iterate on this then.
There was a problem hiding this comment.
Oh, I forgot about the wiki link. Yeah we should put a list there of things that can force async off. Then this warning text is fine.
Aside from being slow, it can make code fail in chrome, so we should warn at compile time when user options force sync compilation.