Accept -O4 and larger values, clamping to -O3 and warning. #5520
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Aug 25, 2017
tests/test_other.py
Outdated
| @@ -2331,7 +2331,7 @@ def test_llvm_nativizer(self): | |||
| output = Popen([os.path.join(self.get_dir(), 'files.o.run')], stdin=open(os.path.join(self.get_dir(), 'stdin')), stdout=PIPE, stderr=PIPE).communicate() | |||
| self.assertContained('''size: 37 | |||
| data: 119,97,107,97,32,119,97,107,97,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35,35 | |||
| loop: 119 97 107 97 32 119 97 107 97 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 | |||
There was a problem hiding this comment.
this test may depend on that whitespace
There was a problem hiding this comment.
maybe worth refactoring the test code so editors don't complain about this (add an explicit + ' ')
kripken
reviewed
Aug 25, 2017
tests/test_other.py
Outdated
| out, err = Popen([PYTHON, EMCC, '-O' + str(level), path_from_root('tests', 'hello_world.c')], stdout=PIPE, stderr=PIPE).communicate() | ||
| assert os.path.exists('a.out.js'), '-O' + str(level) + ' should produce output' | ||
| if level > 3: | ||
| self.assertContained("optimization level '-O" + str(level) + "' is not supported; using '-O3' instead", err) |
|
Thanks, looks good aside from minor comments. |
etienne02
force-pushed
the
large-o-values
branch
from
b778b67
to
ff11d47
Compare
|
Thanks! |
This was referenced Sep 6, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do pull request #3711.
(Sorry for spaces modifications)