Remove duplication in test emcc_args. NFC. #7457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Nov 5, 2018
tests/test_core.py
Outdated
| @@ -7937,6 +7937,10 @@ def make_run(name, emcc_args, env=None): | |||
| if env is None: | |||
| env = {} | |||
|
|
|||
| # Filter out the opt level | |||
| opt_level = [a for a in emcc_args if a.startswith('-O')] | |||
| emcc_args = [a for a in emcc_args if not a.startswith('-O')] | |||
There was a problem hiding this comment.
I think there may be tests that look at -O? in self.emcc_args, and this might break them?
tests/test_core.py
Outdated
| Building.COMPILER_TEST_OPTS.append(arg) # so bitcode is optimized too, this is for cpp to ll | ||
| # so bitcode is optimized too, this is for cpp to ll | ||
| if opt_level: | ||
| Building.COMPILER_TEST_OPTS.append(opt_level[-1]) |
There was a problem hiding this comment.
I read this wrong the first time, thinking opt_level would have to be '-O2' say, and opt_level[-1] would return '2'. Can we canonicalize opt_level = opt_level[-1] if opt_level else None earlier on?
sbc100
force-pushed
the
cleanup_test_args
branch
from
1f4a0cf
to
4d0f48b
Compare
sbc100
force-pushed
the
cleanup_test_args
branch
from
4d0f48b
to
c4895bc
Compare
sbc100
force-pushed
the
cleanup_test_args
branch
from
c4895bc
to
5eaabae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-s and -O flags were appearing twice in emcc arguments