Switch from using load events to DOMContentLoaded events so that logging is available sooner. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing is available sooner
kriserickson
pushed a commit
that referenced
this pull request
Jul 29, 2011
Switch from using load events to DOMContentLoaded events so that logging is available sooner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thing I'm working on was having lots of problems at startup, to the point where ibug wasn't getting me the log info I needed. Tweaking it to use the DOMContentLoaded event instead of the load event fixed things up nicely.
I think most modern browsers have this these days, but I haven't looked at the details, so there may be cross-browser issues to consider before accepting this patch.