Skip to content

Commit

Permalink
.github: Fix smoke tests sysdump collection from failing prematurely
Browse files Browse the repository at this point in the history
If the `hubble observe` command fails for whatever reason, we don't want
to prevent the collection of the sysdump.

Fixes: 0cbb855 (".github: Capture hubble flows when smoke test
fails")
Fixes: cilium#16968

Signed-off-by: Chris Tarazi <chris@isovalent.com>
  • Loading branch information
christarazi authored and Gobinath Krishnamoorthy committed Oct 20, 2021
1 parent 9b730ad commit 1988545
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/tests-smoke-ipv6.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ jobs:
curl -sLO "https://github.com/cilium/hubble/releases/download/${version}/hubble-linux-amd64.tar.gz"
tar zxf hubble-linux-amd64.tar.gz
chmod +x ./hubble
./hubble observe --all --output json > hubble-flows.json
touch hubble-flows.json
./hubble observe --all --output json > hubble-flows.json || true
curl -sLO https://github.com/cilium/cilium-sysdump/releases/latest/download/cilium-sysdump.zip
python cilium-sysdump.zip --output cilium-sysdump-out
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/tests-smoke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ jobs:
curl -sLO https://github.com/cilium/hubble/releases/download/latest/hubble-linux-amd64.tar.gz
tar zxf hubble-linux-amd64.tar.gz
chmod +x ./hubble
./hubble observe --all --output json > hubble-flows.json
touch hubble-flows.json
./hubble observe --all --output json > hubble-flows.json || true
curl -sLO https://github.com/cilium/cilium-sysdump/releases/latest/download/cilium-sysdump.zip
python cilium-sysdump.zip --output cilium-sysdump-out
Expand Down

0 comments on commit 1988545

Please sign in to comment.