Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dense_rw #75

Closed
Tracked by #55
RemyLau opened this issue Feb 12, 2022 · 0 comments · Fixed by #77
Closed
Tracked by #55

dense_rw #75

RemyLau opened this issue Feb 12, 2022 · 0 comments · Fixed by #77

Comments

@RemyLau
Copy link
Contributor

RemyLau commented Feb 12, 2022

No description provided.

@RemyLau RemyLau mentioned this issue Feb 12, 2022
Closed
5 tasks
RemyLau added a commit that referenced this issue Feb 12, 2022
@RemyLau
Type pecanpy base class, closes #73
d384ea4 
Realized that other objects are either less trivially typed (operates on numpy arrays), or not necessary (cli and wrappers).
So close them all, and also close the static typing issue.
Closes #74, closes #75, closes #76
@RemyLau RemyLau linked a pull request Feb 12, 2022 that will close this issue
Static typing and format fixes #77
Merged
RemyLau added a commit that referenced this issue Feb 12, 2022
@RemyLau
Static typing and format fixes (#77)
71dd988 
* Add mypy to test

* Move setter right under property

* Use relative imports; add auto reorder imports to pre commit

* Use property nodes instead of IDlst; make use of num_nodes

* Auto format fix

* Rename IDmap to _node_idmap, use get_node_idx for retreiving node index given node id

* Type BaseGraph and AdjLst

* Type SparseGraph and DenseGraph, closes #72

* Enable distributed testing

* Rename fp to path

* Use relative imports in pecanpy module

* Type pecanpy base class, closes #73

Realized that other objects are either less trivially typed (operates on numpy arrays), or not necessary (cli and wrappers).
So close them all, and also close the static typing issue.
Closes #74, closes #75, closes #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Static typing and format fixes krishnanlab/PecanPy
1 participant
@RemyLau