Fix incorrect version check #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, the version check will ensure that the major version is non-negative AND that the minor version is at least 10. Current versions, with major version 4 or 5 but single-digit minor versions, are not matched by this. Instead we can check whether the major version is at least 1 OR the minor version is at least 10, assuming in the latter case that the major version cannot be less than 0 so we don't have to check for that.
Closed
|
See #159 |
|
(Thank you @nknapp, my apologies for my lack of vigilance on this repository) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of commit 061284b
by Martin Gagern to fix #149
The original commit message is:
As it stands, the version check will ensure that the major version is
non-negative AND that the minor version is at least 10. Current versions,
with major version 4 or 5 but single-digit minor versions, are not matched
by this. Instead we can check whether the major version is at least 1 OR
the minor version is at least 10, assuming in the latter case that the major
version cannot be less than 0 so we don't have to check for that.