The revenge of long stack traces

[domenic]

This makes long stack traces infinite, and changes their API from longStackJumpLimit = 0 | 1 (default 1) to longStackSupport = true | false (default false). Notably, infinite long stack traces come with no real performance or memory penalty over our existing one-level "long" stack traces.

See #264 for some more discussion. In particular, should we switch on the presence of the Web Inspector console and/or (process.env.NODE_ENV || "development") !== "development" in order to turn them on by default?

This also adds a undocumented-for-now API promise.source to every promise that originates inside defer(), i.e. every promise except immediately-fulfilled and immediately-rejected ones. This could be fun for constructing promise graph visualizations, as I was discussing with @brendankenny at JSConf.

[domenic]

@kriskowal after looking into it, Chrome removed the ability to detect if the console was open. And it was kind of hacky anyway, either cluttering your console with "Profile Started ... Profile Ended" or forcing Q to do a console.clear() and lose any console data before Q loads.

Combined with my slight unease about the dominant pattern for NODE_ENV defaulting to development, I think it's best to just leave the long stacks off by default. So, this pull request is good as is.

Any comments before I merge?

[domenic]

@kriskowal when you have time I think this is the only thing I want to get in before doing a 0.9.5. Then we can move on to more experiments like #313 and the nextTick stuff, mwuahaha.

[kriskowal]

This looks good. Would you like me to merge this and cut the release?

[domenic]

Awesome :). Yeah, will do tomorrow—bedtime now!

On Jun 10, 2013, at 1:07, "Kris Kowal" <notifications@github.commailto:notifications@github.com> wrote:

This looks good. Would you like me to merge this and cut the release?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/311#issuecomment-19181017.

[domenic]

Merged as 49d920d and 97f4c6b, w00t (and yay for avoiding merge commits!).