Skip to content

Commit

Permalink
Remove hr and separate some margin normalizations
Browse files Browse the repository at this point in the history
Recommend that people supporting IE6/7 do not use the `hr` element
at all. It requires far more work than just normalizing margins.
IE6/7 do not collapse margins set on `hr` with margins of pre- or
proceeding elements.

Separate the margin normalizations for `p` and `pre` from that for
`h3`. Despite sharing the same margin value, headings are
qualitatively different from these other elements. Both in terms
of customization and debugging using browser tools, it is cleaner
to keep the margins of heading separate.
  • Loading branch information
Krister Kari committed Feb 7, 2012
1 parent d6cdf33 commit 29d0a86
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions normalize.scss
Expand Up @@ -114,11 +114,6 @@ h2 {

h3 {
font-size: 1.17em;
}

h3,
p,
pre {
margin: 1em 0;
}

Expand Down Expand Up @@ -154,12 +149,6 @@ blockquote {
margin: 1em 40px;
}

// Addresses styling not present in IE6/7

hr {
margin: 0.5em auto;
}

// Addresses styling not present in S5, Chrome

dfn {
Expand All @@ -173,6 +162,13 @@ mark {
color: #000;
}

// Addresses margins set differently in IE6/7

p,
pre {
margin: 1em 0;
}

// Corrects font family set oddly in IE6, S4/5, Chrome
// en.wikipedia.org/wiki/User:Davidgothberg/Test59

Expand Down

0 comments on commit 29d0a86

Please sign in to comment.