Rename live -> watch

kristerkari · Jun 9, 2015 · e8d2b31 · e8d2b31
1 parent 97f9411
commit e8d2b31
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 30 deletions.
diff --git a/README.md b/README.md
@@ -58,11 +58,11 @@ __data-placeholder-mode="input"__
 
 Does not hide placeholder on focus, but hides it after user types text to the input field.
 
-### data-placeholder-live
+### data-placeholder-watch
 
 Default: `true`
 
-__data-placeholder-live="false"__
+__data-placeholder-watch="false"__
 
 Disables Placekeeper's feature that watches for placeholder attribute changes on input fields that are currently on the page.
 

diff --git a/src/data.js b/src/data.js
@@ -1,7 +1,7 @@
 (function() {
 
-  function hasLiveUpdatesAttrSetToFalse(element) {
-    return element.getAttribute("data-placeholder-live") === "false";
+  function hasWatchAttrSetToFalse(element) {
+    return element.getAttribute("data-placeholder-watch") === "false";
   }
 
   function hasModeAttrSetToInput(element) {
@@ -89,7 +89,7 @@
   }
 
   placekeeper.data = {
-    hasLiveUpdatesAttrSetToFalse: hasLiveUpdatesAttrSetToFalse,
+    hasWatchAttrSetToFalse: hasWatchAttrSetToFalse,
     hasModeAttrSetToInput: hasModeAttrSetToInput,
     hasEventsAttrSetToTrue: hasEventsAttrSetToTrue,
     hasActiveAttrSetToTrue: hasActiveAttrSetToTrue,

diff --git a/src/main.js b/src/main.js
@@ -122,12 +122,12 @@
     }
     clearInterval(loopInterval);
     placekeeperLoop();
-    if (!mode.hasDisabledLiveUpdates()) {
-      mode.enableLive();
+    if (!mode.hasWatchingDisabled()) {
+      mode.enableWatching();
       // main loop
       loopInterval = setInterval(placekeeperLoop, settings.defaultLoopDuration);
     } else {
-      mode.disableLive();
+      mode.disableWatching();
     }
   }
 
@@ -149,7 +149,7 @@
   placekeeper.enable = init;
   placekeeper.disable = disablePlacekeeper;
   placekeeper.isFocusEnabled = mode.isPlacekeeperFocusEnabled;
-  placekeeper.isLiveUpdateEnabled = mode.isPlacekeeperLiveUpdateEnabled;
+  placekeeper.isWatchingEnabled = mode.isPlacekeeperWatchingEnabled;
 
   // Exposed private methods
   placekeeper.priv = {

diff --git a/src/mode.js b/src/mode.js
@@ -4,7 +4,7 @@
 
   var isEnabled = false;
   var isFocusEnabled = true;
-  var isLiveUpdateEnabled = false;
+  var isWatchingEnabled = false;
 
   function isPlacekeeperEnabled() {
     return isEnabled;
@@ -14,13 +14,13 @@
     return isFocusEnabled;
   }
 
-  function isPlacekeeperLiveUpdateEnabled() {
-    return isLiveUpdateEnabled;
+  function isPlacekeeperWatchingEnabled() {
+    return isWatchingEnabled;
   }
 
-  function hasDisabledLiveUpdates() {
-    return data.hasLiveUpdatesAttrSetToFalse(document.documentElement) ||
-           data.hasLiveUpdatesAttrSetToFalse(document.body);
+  function hasWatchingDisabled() {
+    return data.hasWatchAttrSetToFalse(document.documentElement) ||
+           data.hasWatchAttrSetToFalse(document.body);
   }
 
   function hasFocusDisabled() {
@@ -36,12 +36,12 @@
     isFocusEnabled = false;
   }
 
-  function enableLive() {
-    isLiveUpdateEnabled = true;
+  function enableWatching() {
+    isWatchingEnabled = true;
   }
 
-  function disableLive() {
-    isLiveUpdateEnabled = false;
+  function disableWatching() {
+    isWatchingEnabled = false;
   }
 
   function disable() {
@@ -55,13 +55,13 @@
   placekeeper.mode = {
     isPlacekeeperEnabled: isPlacekeeperEnabled,
     isPlacekeeperFocusEnabled: isPlacekeeperFocusEnabled,
-    isPlacekeeperLiveUpdateEnabled: isPlacekeeperLiveUpdateEnabled,
-    hasDisabledLiveUpdates: hasDisabledLiveUpdates,
+    isPlacekeeperWatchingEnabled: isPlacekeeperWatchingEnabled,
+    hasWatchingDisabled: hasWatchingDisabled,
     hasFocusDisabled: hasFocusDisabled,
     enableFocus: enableFocus,
     disableFocus: disableFocus,
-    enableLive: enableLive,
-    disableLive: disableLive,
+    enableWatching: enableWatching,
+    disableWatching: disableWatching,
     disable: disable,
     enable: enable
   };

diff --git a/test/unit/hide-on-input.spec.js b/test/unit/hide-on-input.spec.js
@@ -13,15 +13,15 @@ describe("hide on input mode", function() {
         helpers.spyOnFocusEnabledAndReturn(false);
         element = helpers.createInputElement(true);
         placekeeper.priv.__setupPlaceholders();
-        placekeeper.mode.enableLive();
+        placekeeper.mode.enableWatching();
       });
 
       afterEach(function() {
         element.parentNode.removeChild(element);
       });
 
-      it("should have live updates enabled", function() {
-        expect(placekeeper.isLiveUpdateEnabled()).toEqual(true);
+      it("should have watching enabled", function() {
+        expect(placekeeper.isWatchingEnabled()).toEqual(true);
       });
 
       it("should have called utils.addEventListener for keydown handler", function() {

diff --git a/test/unit/live.spec.js → test/unit/watch.spec.js b/test/unit/live.spec.js → test/unit/watch.spec.js
@@ -1,9 +1,9 @@
-describe("live updates", function() {
+describe("watching for placeholder changes", function() {
   "use strict";
 
   beforeEach(helpers.initialSetup);
 
-  describe("when live updates are enabled and there is an element with placeholder on the page", function() {
+  describe("when watching enabled and there is an element with placeholder on the page", function() {
     var element;
 
     beforeEach(function(done) {
@@ -22,8 +22,8 @@ describe("live updates", function() {
       expect(element.getAttribute("data-placeholder-value")).toEqual("Test");
     });
 
-    it("should have live updates enabled", function() {
-      expect(placekeeper.isLiveUpdateEnabled()).toEqual(true);
+    it("should have watching enabled", function() {
+      expect(placekeeper.isWatchingEnabled()).toEqual(true);
     });
 
     describe("and when placeholder value is changed", function() {