multidimensional pairwise distance computations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,29 @@ | |||
| import numpy as np | |||
| import scipy.spatial.distance as ssd | |||
| from scipy.stats import spearmanr | |||
|
|
|||
There was a problem hiding this comment.
spearmanr is still susceptible to issues related to columns of all NaN -- we can either create a pull request on the scipy package, fixing this issue, or we can check for columns of all NaNs and replace them with Inf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the fitting procedure into two parts:
Updated the fit method so that it can compute pairwise distance matrices analogous to Scipy's cdist function.
This pairwise computation uses numba to parallelize the iterations over pairs of subspaces.