Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field error class #411

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Add field error class #411

merged 2 commits into from
Feb 24, 2018

Conversation

n7olkachev
Copy link
Contributor

No description provided.

@kristijanhusak
Copy link
Owner

@n7olkachev can you explain a bit what is this PR for?

@n7olkachev
Copy link
Contributor Author

n7olkachev commented Feb 23, 2018 •
edited
Loading

My bad, sorry.
Yep, it's useful because of bootstrap 4 validation, where you need to add is-invalid class to an input itself.

@kristijanhusak
Copy link
Owner

Please update the default config to include that field class, set it to be empty string by default.

@n7olkachev
Copy link
Contributor Author

@kristijanhusak done

@kristijanhusak
Copy link
Owner

Thanks!

@kristijanhusak kristijanhusak merged commit 2817c00 into kristijanhusak:master Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n7olkachev @kristijanhusak