first implementation of span name filters #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the path contains UUID, or Long values, the list of span names explode, In production we see that cassandra is struggling when a huge amount of different span names needs to be inserted into the database.
I created the possibility to add a filter to the span name creation. For the spring rest-easy you can add them by simply creating a config class in your project. Jersey implementation currently takes no filter. Two filters are implemented: No filter and Filter out numeric values which filters path/ab1234/path into path//path. Of course a custom filter for your application can be made.