Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocessor agnostic gutter configuration #101

Closed
timoxley opened this issue Jul 11, 2015 · 8 comments
Closed

preprocessor agnostic gutter configuration #101

timoxley opened this issue Jul 11, 2015 · 8 comments

Comments

@timoxley
Copy link

currently can't see a good way to use npm install to install flexboxgrid if you also need to adjust the gutters.

Kind of sucks there's not really a good way to expose user-configurable variables for style components, even with preprocessors. Not sure a good pre/post processor-agnostic solution other than exposing a css generator and allowing users to pass in the gutter sizes as variables. Perhaps a cli app?

In my case, I want to remove the gutter completely because the gutter makes certain styles impossible, so perhaps the simplest thing that would work would be special-casing zero gutters (due to aforementioned restriction) and including a zero gutters version in the distribution.

@kristoferjoseph
Copy link
Owner

@timoxley Have been working on a solution for this. Got a little hung up by sass compilers not playing nice with each other. Will keep this issue open and comment as I release solutions.
Thanks!

@stereokai
Copy link

Subscribed.

@kristoferjoseph
Copy link
Owner

@timoxley How do you feel about a .gutters class added to the caontainer being needed to get gutters? The default being no gutters.

@stereokai
Copy link

Why not use the sass !default modifier?

@timoxley
Copy link
Author

timoxley commented Aug 2, 2015

@kristoferjoseph That's pretty neat. I like it.

@timoxley
Copy link
Author

@stereokai I'm not using sass hence request for preprocessor agnostic gutter config

@kristoferjoseph
Copy link
Owner

I will be adding the .gutters class in the next release. I am dropping preprocessors entirely because Chrome is shipping custom properties. That is two thirds of evergreen browser!

@kristoferjoseph
Copy link
Owner

At this point you can use the source css in most browsers and adjust the custom properties to adjust the gutters to your hearts content. gutters class is still getting added to the next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants