cleaned up exceptions

lib/Buzz/Client/AbstractCurl.php

@@ -6,7 +6,7 @@
 use Buzz\Message\Form\FormUploadInterface;
 use Buzz\Message\MessageInterface;
 use Buzz\Message\RequestInterface;
-use Buzz\Exception\TransmissionException;
+use Buzz\Exception\ClientException;
 
 /**
  * Base client class with helpers for working with cURL.
@@ -25,7 +25,7 @@ abstract class AbstractCurl extends AbstractClient
     static protected function createCurlHandle()
     {
         if (false === $curl = curl_init()) {
-            throw new TransmissionException('Unable to create a new cURL handle');
+            throw new ClientException('Unable to create a new cURL handle');
         }
 
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

lib/Buzz/Client/Curl.php

@@ -4,7 +4,7 @@
 
 use Buzz\Message\MessageInterface;
 use Buzz\Message\RequestInterface;
-use Buzz\Exception\TransmissionException;
+use Buzz\Exception\ClientException;
 use Buzz\Exception\LogicException;
 
 class Curl extends AbstractCurl implements ClientInterface
@@ -26,7 +26,7 @@ public function send(RequestInterface $request, MessageInterface $response, arra
             $errorMsg = curl_error($this->lastCurl);
             $errorNo  = curl_errno($this->lastCurl);
 
-            throw new TransmissionException($errorMsg, $errorNo);
+            throw new ClientException($errorMsg, $errorNo);
         }
 
         static::populateResponse($this->lastCurl, $data, $response);

lib/Buzz/Client/FileGetContents.php

@@ -5,7 +5,7 @@
 use Buzz\Message\MessageInterface;
 use Buzz\Message\RequestInterface;
 use Buzz\Util\CookieJar;
-use Buzz\Exception\TransmissionException;
+use Buzz\Exception\ClientException;
 
 class FileGetContents extends AbstractStream implements ClientInterface
 {
@@ -31,7 +31,7 @@ public function getCookieJar()
     /**
      * @see ClientInterface
      *
-     * @throws TransmissionException If file_get_contents() fires an error
+     * @throws ClientException If file_get_contents() fires an error
      */
     public function send(RequestInterface $request, MessageInterface $response)
     {
@@ -48,7 +48,7 @@ public function send(RequestInterface $request, MessageInterface $response)
         error_reporting($level);
         if (false === $content) {
             $error = error_get_last();
-            throw new TransmissionException($error['message']);
+            throw new ClientException($error['message']);
         }
 
         $response->setHeaders($this->filterHeaders((array) $http_response_header));

lib/Buzz/Exception/ClientException.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Buzz\Exception;
+
+/**
+ * Thrown whenever a client process fails.
+ */
+class ClientException extends RuntimeException
+{
+}

lib/Buzz/Exception/BuzzException.php → lib/Buzz/Exception/ExceptionInterface.php

@@ -1,9 +1,10 @@
 <?php
+
 namespace Buzz\Exception;
 
 /**
- * Marker interface to denote exceptions thrown from the Buzz context
+ * Marker interface to denote exceptions thrown from the Buzz context.
  */
-interface BuzzException
+interface ExceptionInterface
 {
 }

lib/Buzz/Exception/InvalidArgumentException.php

@@ -3,8 +3,8 @@
 namespace Buzz\Exception;
 
 /**
- * Thrown when an invalid argument is provided
+ * Thrown when an invalid argument is provided.
  */
-class InvalidArgumentException extends \InvalidArgumentException implements BuzzException
+class InvalidArgumentException extends \InvalidArgumentException implements ExceptionInterface
 {
-}
+}

lib/Buzz/Exception/LogicException.php

@@ -3,8 +3,8 @@
 namespace Buzz\Exception;
 
 /**
- * Thrown whenever a required call-flow is not respected
+ * Thrown whenever a required call-flow is not respected.
  */
-class LogicException extends \LogicException implements BuzzException
+class LogicException extends \LogicException implements ExceptionInterface
 {
-}
+}

lib/Buzz/Exception/RuntimeException.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Buzz\Exception;
+
+class RuntimeException extends \RuntimeException implements ExceptionInterface
+{
+}

test/Buzz/Test/Client/FileGetContentsTest.php

@@ -12,7 +12,7 @@ class FileGetContentsTest extends \PHPUnit_Framework_TestCase
      */
     public function testSendToInvalidUrl($host)
     {
-        $this->setExpectedException('Buzz\Exception\TransmissionException');
+        $this->setExpectedException('Buzz\Exception\ClientException');
 
         $request = new Message\Request();
         $request->fromUrl('http://'.$host.':12345');