Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Buzz specific exceptions? #79

Closed
asm89 opened this issue Jun 4, 2012 · 8 comments
Closed

More Buzz specific exceptions? #79

asm89 opened this issue Jun 4, 2012 · 8 comments

Comments

@asm89
Copy link
Contributor

asm89 commented Jun 4, 2012

For example the Curl client throws a RuntimeException if curl returns an error. Would it be an idea to extend the RuntimeException with a Buzz\Exception\ClientException class or something?

Reason I'm asking is because we have long running processes consuming an api. Sometimes this API fails and the RuntimeException bubbles up. It would be nice to be able to catch the exceptions generated by Buzz and then requeue the current message being processed and go on with the next one. Currently the process crashes.

@kriswallsmith
Copy link
Owner

👍

@juliendidier
Copy link

cURL is the only class which throws Exceptions.

@asm89
Copy link
Contributor Author

asm89 commented Jun 27, 2012

@juliendidier No, the FileGetContents and the MultiCurl class also throw exceptions.

@juliendidier
Copy link

Could you make a PR for that ?

@stloyd
Copy link
Contributor

stloyd commented Feb 19, 2013

@kriswallsmith This can be closed as new exceptions were introduced.

@kriswallsmith
Copy link
Owner

RequestException is not useful?

On Mon, Feb 18, 2013 at 4:15 PM, Joseph Bielawski
notifications@github.comwrote:

@kriswallsmith https://github.com/kriswallsmith This can be closed as
new exceptions were introduced.


Reply to this email directly or view it on GitHubhttps://github.com//issues/79#issuecomment-13750354.

@stloyd
Copy link
Contributor

stloyd commented Feb 19, 2013

You have set ClientException which covers this needs I would say.

@Nyholm
Copy link
Collaborator

Nyholm commented Mar 17, 2018

We will implement PSR-18 exceptions.

Im closing this because it is super old =)

@Nyholm Nyholm closed this as completed Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants