cURL Compatibility Improvement #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating `prepare()` so that it considers the current PHP environment. `safe_mode` and `open_basedir` will not allow `cURL` to `FOLLOWLOCATION`. See also: http://www.edmondscommerce.co.uk/curl/php-curl-curlopt_followlocation-and-open_basedir-or-safe-mode/
| @@ -189,9 +189,11 @@ protected function prepare($curl, RequestInterface $request, array $options = ar | |||
| if ($this->proxy) { | |||
| curl_setopt($curl, CURLOPT_PROXY, $this->proxy); | |||
| } | |||
|
|
|||
| $can_follow = (!ini_get('safe_mode') && !ini_get('open_basedir')); | |||
There was a problem hiding this comment.
Please use camelcased variabled names.
And the braces are useless
Using camelCase and removing brackets.
|
Done :-) Thank you. |
kriswallsmith
added a commit
that referenced
this pull request
May 19, 2013
cURL Compatibility Improvement
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
prepare()so that it considers the current PHP environment.safe_modeandopen_basedirwill not allowcURLtoFOLLOWLOCATION.See also: http://www.edmondscommerce.co.uk/curl/php-curl-curlopt_followlocation-and-open_basedir-or-safe-mode/